Bug 146760 - Expose bounds of AVVideoCaptureSource
Summary: Expose bounds of AVVideoCaptureSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthew Daiter
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks: 146746
  Show dependency tree / graph
 
Reported: 2015-07-08 17:21 PDT by Matthew Daiter
Modified: 2015-07-09 11:50 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2015-07-08 17:24 PDT, Matthew Daiter 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Daiter 2015-07-08 17:21:41 PDT 
Need to expose width and height of AVVideoCaptureSource to correctly bound the box of getUserMedia()
Comment 1 Radar WebKit Bug Importer 2015-07-08 17:23:29 PDT 
<rdar://problem/21736772>
Comment 2 Matthew Daiter 2015-07-08 17:24:11 PDT 
Created attachment 256437 [details]
Patch
Comment 3 Brent Fulgham 2015-07-08 18:35:15 PDT 
Comment on attachment 256437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256437&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:45
> +    virtual int32_t height() const { return m_height; }

Why are these virtual? Are they overridden in another class?
Comment 4 Brent Fulgham 2015-07-09 11:01:12 PDT 
Comment on attachment 256437 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2015-07-09 11:49:59 PDT 
Comment on attachment 256437 [details]
Patch

Clearing flags on attachment: 256437

Committed r186600: <http://trac.webkit.org/changeset/186600>
Comment 6 WebKit Commit Bot 2015-07-09 11:50:02 PDT 
All reviewed patches have been landed.  Closing bug.