Bug 146759 - Web Inspector: Only record a timeline when the Timelines tab is showing
Summary: Web Inspector: Only record a timeline when the Timelines tab is showing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-08 17:18 PDT by Timothy Hatcher
Modified: 2015-07-08 18:15 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.31 KB, patch)
2015-07-08 17:18 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-07-08 17:18:12 PDT
Now that we have a Network tab, lets only record a timeline when the Timelines tab is showing.
Comment 1 Radar WebKit Bug Importer 2015-07-08 17:18:40 PDT
<rdar://problem/21736695>
Comment 2 Timothy Hatcher 2015-07-08 17:18:54 PDT
Created attachment 256434 [details]
Patch
Comment 3 Joseph Pecoraro 2015-07-08 17:25:09 PDT
Comment on attachment 256434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256434&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:85
> +    set autoCaptureOnPageLoad(autoCapture)
> +    {
> +        this._autoCaptureOnPageLoad = autoCapture;
> +    }

When we want to move this to the backend, it would be as easy as adding a backend message here (TimelineAgent.setAutoCaptureOnPageLoad(autoCapture)). I like it!
Comment 4 WebKit Commit Bot 2015-07-08 18:15:10 PDT
Comment on attachment 256434 [details]
Patch

Clearing flags on attachment: 256434

Committed r186561: <http://trac.webkit.org/changeset/186561>
Comment 5 WebKit Commit Bot 2015-07-08 18:15:17 PDT
All reviewed patches have been landed.  Closing bug.