WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
146551
Build fix for Win EWS bot
https://bugs.webkit.org/show_bug.cgi?id=146551
Summary
Build fix for Win EWS bot
Mark Lam
Reported
2015-07-02 10:48:52 PDT
The Win EWS bot is not liking the NO_RETURN attribute in JSDollarVMPrototype's functionCrash(). Let's fix it.
Attachments
patch 1: let's see if the Win EWS likes this.
(1.23 KB, patch)
2015-07-02 10:52 PDT
,
Mark Lam
no flags
Details
Formatted Diff
Diff
patch 2: try getting rid of the NO_RETURN attribute altogether.
(1.31 KB, patch)
2015-07-02 11:17 PDT
,
Mark Lam
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2015-07-02 10:52:27 PDT
Created
attachment 256016
[details]
patch 1: let's see if the Win EWS likes this.
Mark Lam
Comment 2
2015-07-02 11:17:48 PDT
Created
attachment 256019
[details]
patch 2: try getting rid of the NO_RETURN attribute altogether.
Mark Lam
Comment 3
2015-07-02 11:46:32 PDT
The Win EWS bot is happy with the patch. I landed it without review as a build fix. Landed in
r186230
: <
http://trac.webkit.org/r186230
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug