Bug 146551 - Build fix for Win EWS bot
Summary: Build fix for Win EWS bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-02 10:48 PDT by Mark Lam
Modified: 2015-07-02 11:46 PDT (History)
0 users

See Also:

Attachments
patch 1: let's see if the Win EWS likes this. (1.23 KB, patch)
2015-07-02 10:52 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
patch 2: try getting rid of the NO_RETURN attribute altogether. (1.31 KB, patch)
2015-07-02 11:17 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-07-02 10:48:52 PDT 
The Win EWS bot is not liking the NO_RETURN attribute in JSDollarVMPrototype's functionCrash().  Let's fix it.
Comment 1 Mark Lam 2015-07-02 10:52:27 PDT 
Created attachment 256016 [details]
patch 1: let's see if the Win EWS likes this.
Comment 2 Mark Lam 2015-07-02 11:17:48 PDT 
Created attachment 256019 [details]
patch 2: try getting rid of the NO_RETURN attribute altogether.
Comment 3 Mark Lam 2015-07-02 11:46:32 PDT 
The Win EWS bot is happy with the patch.  I landed it without review as a build fix.

Landed in r186230: <http://trac.webkit.org/r186230>.