Bug 146540 - iOS WebKitLegacy should match WebKit2's viewport behavior
Summary: iOS WebKitLegacy should match WebKit2's viewport behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-02 00:03 PDT by Tim Horton
Modified: 2015-07-03 11:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.49 KB, patch)
2015-07-02 00:05 PDT, Tim Horton 		mitz: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-07-02 00:03:09 PDT 
iOS WebKitLegacy should match WebKit2's viewport behavior
Comment 1 Tim Horton 2015-07-02 00:05:48 PDT 
Created attachment 255994 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-02 00:08:02 PDT 
Attachment 255994 [details] did not pass style-queue:


ERROR: Source/WebKit/ios/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2015-07-02 00:34:28 PDT 
Comment on attachment 255994 [details]
Patch

Rejecting attachment 255994 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 255994, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/ios/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6726243328196608
Comment 4 Tim Horton 2015-07-02 00:37:42 PDT 
http://trac.webkit.org/changeset/186223