Bug 146433 - Web Inspector: iOS 8: Resources Timeline Data does not show up
Summary: Web Inspector: iOS 8: Resources Timeline Data does not show up
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-29 15:40 PDT by Joseph Pecoraro
Modified: 2015-06-29 17:28 PDT (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (12.55 KB, patch)
2015-06-29 15:49 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-06-29 15:40:48 PDT 
* SUMMARY
iOS 8: Resources Timeline Data does not show up.

* STEPS TO REPRODUCE
1. Load webkit.org on iOS 8 device
2. Inspect iOS 8 device
3. Show Timelines tab
4. Reload page
  => no timeline data
Comment 1 Joseph Pecoraro 2015-06-29 15:41:21 PDT 
<rdar://problem/21558990>
Comment 2 Joseph Pecoraro 2015-06-29 15:49:48 PDT 
Created attachment 255786 [details]
[PATCH] Proposed Fix

This is relatively ugly, but I couldn't really think up of a better approach. No matter how early we try to reset the base timestamp, it will never be right, because the "will send request" for the navigation's new main resource, will have always happened in the previous page's "timeline". Let me know what you think.
Comment 3 WebKit Commit Bot 2015-06-29 15:52:47 PDT 
Attachment 255786 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebInspectorUI/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Timothy Hatcher 2015-06-29 17:00:48 PDT 
Comment on attachment 255786 [details]
[PATCH] Proposed Fix

Looks good.
Comment 5 WebKit Commit Bot 2015-06-29 17:28:25 PDT 
Comment on attachment 255786 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 255786

Committed r186098: <http://trac.webkit.org/changeset/186098>
Comment 6 WebKit Commit Bot 2015-06-29 17:28:28 PDT 
All reviewed patches have been landed.  Closing bug.