146419 – AX: PlatformSpeechSynthesizer code doesn't catch Objective-C exceptions

Bug 146419 - AX: PlatformSpeechSynthesizer code doesn't catch Objective-C exceptions

Summary: AX: PlatformSpeechSynthesizer code doesn't catch Objective-C exceptions

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Accessibility (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	chris fleizach

URL:
Keywords:	InRadar

Depends on:
Blocks:

Attachments
patch (3.15 KB, patch) 2015-06-29 16:09 PDT, chris fleizach	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Fraser (smfr) 2015-06-29 13:16:32 PDT

All the code in PlatformSpeechSynthesizer that calls into Objective-C needs to be wrapped in BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS

Comment 1 Radar WebKit Bug Importer 2015-06-29 13:17:03 PDT

<rdar://problem/21597509>

Comment 2 chris fleizach 2015-06-29 16:09:45 PDT

Created attachment 255790 [details]
patch

Comment 3 WebKit Commit Bot 2015-06-29 17:25:00 PDT

Comment on attachment 255790 [details]
patch

Clearing flags on attachment: 255790

Committed r186097: <http://trac.webkit.org/changeset/186097>

Comment 4 WebKit Commit Bot 2015-06-29 17:25:03 PDT

All reviewed patches have been landed.  Closing bug.