Bug 146392 - Web Inspector: Wrong border color of console messages when filters are enabled
Summary: Web Inspector: Wrong border color of console messages when filters are enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-27 21:45 PDT by Nikita Vasilyev
Modified: 2015-06-28 00:44 PDT (History)
8 users (show)

See Also:


Attachments
[Animated GIF] Actual/expected (4.53 KB, image/gif)
2015-06-27 21:45 PDT, Nikita Vasilyev
no flags Details
Patch (1.70 KB, patch)
2015-06-27 21:49 PDT, Nikita Vasilyev
timothy: review+
Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2015-06-27 23:54 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-06-27 21:45:07 PDT
Created attachment 255718 [details]
[Animated GIF] Actual/expected

Steps:

1.
console.warn('a');
console.log('b');
console.warn('c');

console.error('d');
console.log('e');
console.error('f');

2. Turn errors filter on.
Comment 1 Radar WebKit Bug Importer 2015-06-27 21:45:23 PDT
<rdar://problem/21581992>
Comment 2 Nikita Vasilyev 2015-06-27 21:49:17 PDT
Created attachment 255719 [details]
Patch
Comment 3 Timothy Hatcher 2015-06-27 22:46:45 PDT
Comment on attachment 255719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255719&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:53
> +.console-error-level.console-item:not(.filtered-out):not(.filtered-out-by-search),

Could be :not(.filtered-out, .filtered-out-by-search)

> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:54
> +.console-error-level:not(.filtered-out):not(.filtered-out-by-search) + .console-item {

Ditto.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:58
> +.console-warning-level.console-item:not(.filtered-out):not(.filtered-out-by-search),

Ditto.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:59
> +.console-warning-level:not(.filtered-out):not(.filtered-out-by-search) + .console-item {

Ditto.
Comment 4 Nikita Vasilyev 2015-06-27 23:54:37 PDT
Created attachment 255721 [details]
Patch
Comment 5 WebKit Commit Bot 2015-06-28 00:44:07 PDT
Comment on attachment 255721 [details]
Patch

Clearing flags on attachment: 255721

Committed r186042: <http://trac.webkit.org/changeset/186042>
Comment 6 WebKit Commit Bot 2015-06-28 00:44:11 PDT
All reviewed patches have been landed.  Closing bug.