Bug 146357 - [WinCairo] Enable WEB_TIMING.
Summary: [WinCairo] Enable WEB_TIMING.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-26 12:22 PDT by peavo
Modified: 2015-06-26 15:29 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.31 KB, patch)
2015-06-26 12:32 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-06-26 12:22:09 PDT
Windows recently enabled WEB_TIMING, I believe WinCairo can enable it aswell.
Comment 1 peavo 2015-06-26 12:32:58 PDT
Created attachment 255660 [details]
Patch
Comment 2 Brent Fulgham 2015-06-26 13:35:45 PDT
Comment on attachment 255660 [details]
Patch

r=me.
Comment 3 peavo 2015-06-26 13:38:16 PDT
(In reply to comment #2)
> Comment on attachment 255660 [details]
> Patch
> 
> r=me.

Thanks :)
Comment 4 Alex Christensen 2015-06-26 14:22:06 PDT
Comment on attachment 255660 [details]
Patch

This was disabled in http://trac.webkit.org/changeset/185993 as a build fix.  WinCairo does not compile with WEB_TIMING enabled.  https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/46802/steps/compile-webkit/logs/stdio
Comment 5 peavo 2015-06-26 14:38:42 PDT
Comment on attachment 255660 [details]
Patch

The compile errors are hopefully fixed in http://trac.webkit.org/changeset/186000
Comment 6 WebKit Commit Bot 2015-06-26 15:29:33 PDT
Comment on attachment 255660 [details]
Patch

Clearing flags on attachment: 255660

Committed r186013: <http://trac.webkit.org/changeset/186013>
Comment 7 WebKit Commit Bot 2015-06-26 15:29:38 PDT
All reviewed patches have been landed.  Closing bug.