Bug 146354 – Make NetworkCache::traverse faster

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Antti Koivisto]

Currently it reads one file at a time making it slow.

[Antti Koivisto]

Created attachment 255655 [details]
patch

[WebKit Commit Bot]

Attachment 255655 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:91:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:107:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 255655 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255655&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:107
> +void IOChannel::write(size_t offset, const Data& data, WorkQueue* queue, const std::function<void (int error)>& completionHandler)

I don't think this should be a const& since that's an extra copy.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:704
> +    std::unique_ptr<TraverseOperation> traverseOperationPtr(new TraverseOperation { flags, WTF::move(traverseHandler) });

auto + std::make_unique?

[Carlos Garcia Campos]

Antti, please, consider fixing GTK+ build before landing. You just need to do the same changes in NetworkCacheIOChannelSoup.cpp and include <condition_variable> in NetworkCacheStorage.cpp

[Antti Koivisto]

Created attachment 255698 [details]
patch

[WebKit Commit Bot]

Attachment 255698 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

http://trac.webkit.org/changeset/186025