RESOLVED FIXED 146316
[SOUP] NetworkCache: Make NetworkProcess::clearDiskCache actually clear the the resources depending on the date 
https://bugs.webkit.org/show_bug.cgi?id=146316
Summary [SOUP] NetworkCache: Make NetworkProcess::clearDiskCache actually clear the t...
Carlos Garcia Campos
Reported 2015-06-25 08:20:23 PDT
And make sure the completion handler is called, as well. This functionality is already implemented in Storage::clear(), so we just need to pass the time point and completion handler to Cache::clear().
Attachments
Patch (2.07 KB, patch)
2015-06-25 08:23 PDT, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-06-25 08:23:11 PDT
Created attachment 255555 [details] Patch
WebKit Commit Bot
Comment 2 2015-06-25 08:25:06 PDT
Attachment 255555 [details] did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:156: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sergio Villar Senin
Comment 3 2015-06-26 00:14:21 PDT
Comment on attachment 255555 [details] Patch Don't we have layout tests for this?
Carlos Garcia Campos
Comment 4 2015-06-26 00:35:23 PDT
(In reply to comment #3) > Comment on attachment 255555 [details] > Patch > > Don't we have layout tests for this? I don't think so, this is more for an API test I think, and there will be one for GTK+ when we expose clear_cache in WebKitWebsiteDataManager. Writing that unit tests is how I noticed this issue, indeed.
Carlos Garcia Campos
Comment 5 2015-06-27 00:43:34 PDT
Committed r186022: <http://trac.webkit.org/changeset/186022>
Note You need to log in before you can comment on or make changes to this bug.