WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
146308
Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes
https://bugs.webkit.org/show_bug.cgi?id=146308
Summary
Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes
Jaehun Lim
Reported
2015-06-24 23:45:45 PDT
ENABLE_CSS3_CONDITIONAL_RULES guard was removed from
r174536
.
Attachments
Patch
(1.54 KB, patch)
2015-06-24 23:48 PDT
,
Jaehun Lim
no flags
Details
Formatted Diff
Diff
Patch
(1.75 KB, patch)
2015-06-25 15:49 PDT
,
Jaehun Lim
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jaehun Lim
Comment 1
2015-06-24 23:48:03 PDT
Created
attachment 255541
[details]
Patch
Csaba Osztrogonác
Comment 2
2015-06-25 01:50:54 PDT
Comment on
attachment 255541
[details]
Patch LGTM, good catch. But please remove $css3ConditionalRulesSupport too from line 56 before landing.
Jaehun Lim
Comment 3
2015-06-25 15:49:23 PDT
Created
attachment 255582
[details]
Patch
Jaehun Lim
Comment 4
2015-06-25 15:50:41 PDT
(In reply to
comment #2
)
> Comment on
attachment 255541
[details]
> Patch > > LGTM, good catch. But please remove $css3ConditionalRulesSupport too from > line 56 before landing.
Thanks. I updated.
WebKit Commit Bot
Comment 5
2015-06-25 16:39:50 PDT
Comment on
attachment 255582
[details]
Patch Clearing flags on attachment: 255582 Committed
r185970
: <
http://trac.webkit.org/changeset/185970
>
WebKit Commit Bot
Comment 6
2015-06-25 16:39:54 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug