Bug 146308 - Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes
Summary: Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jaehun Lim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-24 23:45 PDT by Jaehun Lim
Modified: 2015-06-25 16:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.54 KB, patch)
2015-06-24 23:48 PDT, Jaehun Lim
no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2015-06-25 15:49 PDT, Jaehun Lim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaehun Lim 2015-06-24 23:45:45 PDT
ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
Comment 1 Jaehun Lim 2015-06-24 23:48:03 PDT
Created attachment 255541 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-06-25 01:50:54 PDT
Comment on attachment 255541 [details]
Patch

LGTM, good catch. But please remove $css3ConditionalRulesSupport too from line 56 before landing.
Comment 3 Jaehun Lim 2015-06-25 15:49:23 PDT
Created attachment 255582 [details]
Patch
Comment 4 Jaehun Lim 2015-06-25 15:50:41 PDT
(In reply to comment #2)
> Comment on attachment 255541 [details]
> Patch
> 
> LGTM, good catch. But please remove $css3ConditionalRulesSupport too from
> line 56 before landing.

Thanks. I updated.
Comment 5 WebKit Commit Bot 2015-06-25 16:39:50 PDT
Comment on attachment 255582 [details]
Patch

Clearing flags on attachment: 255582

Committed r185970: <http://trac.webkit.org/changeset/185970>
Comment 6 WebKit Commit Bot 2015-06-25 16:39:54 PDT
All reviewed patches have been landed.  Closing bug.