WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
146117
Fix crash when entering fullscreen during exit fullscreen animation.
https://bugs.webkit.org/show_bug.cgi?id=146117
Summary
Fix crash when entering fullscreen during exit fullscreen animation.
Jeremy Jones
Reported
2015-06-18 12:26:58 PDT
Fix crash when entering fullscreen during exit fullscreen animation.
Attachments
Patch
(6.43 KB, patch)
2015-06-18 12:36 PDT
,
Jeremy Jones
simon.fraser
: review+
Details
Formatted Diff
Diff
Patch for landing.
(6.34 KB, patch)
2015-06-18 15:43 PDT
,
Jeremy Jones
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jeremy Jones
Comment 1
2015-06-18 12:36:04 PDT
Created
attachment 255123
[details]
Patch
Jeremy Jones
Comment 2
2015-06-18 12:36:58 PDT
rdar://problem/20692847
Simon Fraser (smfr)
Comment 3
2015-06-18 13:45:36 PDT
Comment on
attachment 255123
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=255123&action=review
> Source/WebCore/ChangeLog:8 > + If exitFullscreen is called from javascript, it may be called from mainThread.
I don't think this line adds anything.
Jeremy Jones
Comment 4
2015-06-18 15:43:33 PDT
Created
attachment 255144
[details]
Patch for landing.
Jeremy Jones
Comment 5
2015-06-18 15:43:51 PDT
(In reply to
comment #3
)
> Comment on
attachment 255123
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=255123&action=review
> > > Source/WebCore/ChangeLog:8 > > + If exitFullscreen is called from javascript, it may be called from mainThread. > > I don't think this line adds anything.
Removed.
WebKit Commit Bot
Comment 6
2015-06-18 16:39:38 PDT
Comment on
attachment 255144
[details]
Patch for landing. Clearing flags on attachment: 255144 Committed
r185726
: <
http://trac.webkit.org/changeset/185726
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug