Bug 146117 - Fix crash when entering fullscreen during exit fullscreen animation.
Summary: Fix crash when entering fullscreen during exit fullscreen animation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-18 12:26 PDT by Jeremy Jones
Modified: 2015-06-18 16:58 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.43 KB, patch)
2015-06-18 12:36 PDT, Jeremy Jones
simon.fraser: review+
Details | Formatted Diff | Diff
Patch for landing. (6.34 KB, patch)
2015-06-18 15:43 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2015-06-18 12:26:58 PDT
Fix crash when entering fullscreen during exit fullscreen animation.
Comment 1 Jeremy Jones 2015-06-18 12:36:04 PDT
Created attachment 255123 [details]
Patch
Comment 2 Jeremy Jones 2015-06-18 12:36:58 PDT
rdar://problem/20692847
Comment 3 Simon Fraser (smfr) 2015-06-18 13:45:36 PDT
Comment on attachment 255123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255123&action=review

> Source/WebCore/ChangeLog:8
> +        If exitFullscreen is called from javascript, it may be called from mainThread.

I don't think this line adds anything.
Comment 4 Jeremy Jones 2015-06-18 15:43:33 PDT
Created attachment 255144 [details]
Patch for landing.
Comment 5 Jeremy Jones 2015-06-18 15:43:51 PDT
(In reply to comment #3)
> Comment on attachment 255123 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255123&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        If exitFullscreen is called from javascript, it may be called from mainThread.
> 
> I don't think this line adds anything.

Removed.
Comment 6 WebKit Commit Bot 2015-06-18 16:39:38 PDT
Comment on attachment 255144 [details]
Patch for landing.

Clearing flags on attachment: 255144

Committed r185726: <http://trac.webkit.org/changeset/185726>