Bug 146108 - [EFL] Use SET_AND_EXPOSE_TO_BUILD instead of definitions
Summary: [EFL] Use SET_AND_EXPOSE_TO_BUILD instead of definitions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-18 04:37 PDT by Ryuan Choi
Modified: 2015-06-18 16:36 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2015-06-18 04:41 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2015-06-18 04:37:50 PDT 
Since r183416, OptionsGTK uses SET_AND_EXPOSE_TO_BUILD to add definitions to both CMake and compiler.
EFL port also can use it to simplify definitions.
Comment 1 Ryuan Choi 2015-06-18 04:41:23 PDT 
Created attachment 255107 [details]
Patch
Comment 2 Gyuyoung Kim 2015-06-18 07:26:06 PDT 
Comment on attachment 255107 [details]
Patch

LGTM
Comment 3 WebKit Commit Bot 2015-06-18 16:36:07 PDT 
Comment on attachment 255107 [details]
Patch

Clearing flags on attachment: 255107

Committed r185725: <http://trac.webkit.org/changeset/185725>
Comment 4 WebKit Commit Bot 2015-06-18 16:36:12 PDT 
All reviewed patches have been landed.  Closing bug.