Bug 146059 - GObject and ObjC bindings generator should not generate code for promise-based APIs
Summary: GObject and ObjC bindings generator should not generate code for promise-base...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-17 06:18 PDT by youenn fablet
Modified: 2015-06-18 00:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.99 KB, patch)
2015-06-17 06:24 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-06-17 06:18:30 PDT 
In case of a function returning a promise, GObject and ObjC may generate bindings for that function.
The issue is that the returned type Promise may not be supported yet.
It may be safer to disable binding generation for these functions, at least until Promise returned values are support by GObject and ObjC
Comment 1 youenn fablet 2015-06-17 06:24:17 PDT 
Created attachment 255014 [details]
Patch
Comment 2 Darin Adler 2015-06-17 15:23:35 PDT 
Comment on attachment 255014 [details]
Patch

Seems OK for now since we don’t have a strategy for binding these yet.
Comment 3 WebKit Commit Bot 2015-06-18 00:03:40 PDT 
Comment on attachment 255014 [details]
Patch

Clearing flags on attachment: 255014

Committed r185694: <http://trac.webkit.org/changeset/185694>
Comment 4 WebKit Commit Bot 2015-06-18 00:03:44 PDT 
All reviewed patches have been landed.  Closing bug.