Bug 146053 - [GTK] WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER doesn't disable memory cache when set before the web process is launched
Summary: [GTK] WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER doesn't disable memory cache when se...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-06-17 02:30 PDT by Carlos Garcia Campos
Modified: 2015-06-17 08:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.90 KB, patch)
2015-06-17 02:34 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-06-17 02:30:03 PDT
The cache is disabled in WebProcess::platformSetCacheModel() when the cache model is CacheModelDocumentViewer, but it's enabled again by WebProcess::setMemoryCacheDisabled() when memoryCacheDisabled creation parameter is processed. We need to make sure the cache model and memoryCacheDisabled parameters are consistent.
Comment 1 Carlos Garcia Campos 2015-06-17 02:34:34 PDT
Created attachment 255008 [details]
Patch

Unfortunately we don't have a way to check that memory cache is actually disabled in a unit test. Maybe if we eventually implement the WebsiteDataStore, we can get the origins, but for now, it doesn't seem to be possible.
Comment 2 Carlos Garcia Campos 2015-06-17 08:33:26 PDT
Committed r185651: <http://trac.webkit.org/changeset/185651>