Bug 146037 - Safari tabs still have shrunken content after coming out of fullscreen
Summary: Safari tabs still have shrunken content after coming out of fullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-16 16:57 PDT by Tim Horton
Modified: 2015-06-17 12:24 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.34 KB, patch)
2015-06-16 16:57 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (12.51 KB, patch)
2015-06-17 12:17 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-06-16 16:57:20 PDT
Safari tabs still have shrunken content after coming out of fullscreen
Comment 1 Tim Horton 2015-06-16 16:57:38 PDT
Created attachment 254980 [details]
Patch
Comment 2 mitz 2015-06-16 17:01:38 PDT
Can you add an API test?
Comment 3 Darin Adler 2015-06-16 19:34:37 PDT
(In reply to comment #2)
> Can you add an API test?

Does seem like a good idea to do that.

Also seems worth thinking over whether it’s OK to have a race condition here with these short circuits long term.
Comment 4 Tim Horton 2015-06-17 12:17:23 PDT
Created attachment 255029 [details]
Patch
Comment 5 Tim Horton 2015-06-17 12:18:38 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > Can you add an API test?
> 
> Does seem like a good idea to do that.
> 
> Also seems worth thinking over whether it’s OK to have a race condition here
> with these short circuits long term.

Agreed! There are a bunch of these (page scale factor also immediately comes to mind), and they always trip me up.
Comment 6 WebKit Commit Bot 2015-06-17 12:18:45 PDT
Attachment 255029 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:46:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:61:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:76:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Tim Horton 2015-06-17 12:24:54 PDT
http://trac.webkit.org/changeset/185661