Bug 14603 - WebKitQt/WebCoreSupport is in INCLUDES for gdk-port
Summary: WebKitQt/WebCoreSupport is in INCLUDES for gdk-port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Linux
: P4 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-13 05:47 PDT by Oleg Sukhodolsky
Modified: 2007-09-03 06:56 PDT (History)
0 users

See Also:


Attachments
gtk port does not need WebKitQt/WebCoreSupport (582 bytes, patch)
2007-08-18 07:45 PDT, Oleg Sukhodolsky
mjs: review-
Details | Formatted Diff | Diff
the patch with the record for ChangeLog (1.03 KB, patch)
2007-08-20 11:47 PDT, Oleg Sukhodolsky
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sukhodolsky 2007-07-13 05:47:20 PDT
For some reasons WebKitQt/WebCoreSupport is added to INCLUDES unconditionally.
It looks like it shouldn't be.  At least is not needed for gdk-port and, I suspect, that Windows and Mac also do not need it.
Here is a possible fix for this:

--- WebCore/WebCore.pro (revision 24253)
+++ WebCore/WebCore.pro (working copy)
@@ -114,8 +114,8 @@
                 $$PWD/html \
                 $$PWD/bindings/js \
                 $$PWD/ksvg2 $$PWD/ksvg2/css $$PWD/ksvg2/svg $$PWD/ksvg2/misc $$PWD/ksvg2/events \
-                $$PWD/platform/image-decoders \
-                $$PWD/../WebKitQt/WebCoreSupport
+                $$PWD/platform/image-decoders
+
 QT += network
Comment 1 Oleg Sukhodolsky 2007-08-18 07:45:29 PDT
Created attachment 16015 [details]
gtk port does not need WebKitQt/WebCoreSupport
Comment 2 Holger Freyther 2007-08-18 08:40:42 PDT
Agreed.
Comment 3 Maciej Stachowiak 2007-08-19 13:07:54 PDT
Comment on attachment 16015 [details]
gtk port does not need WebKitQt/WebCoreSupport

Change looks good. Please write a ChangeLog entry. r- for lack of ChangeLog entry, will r+ once that is added.
Comment 4 Oleg Sukhodolsky 2007-08-20 11:47:56 PDT
Created attachment 16033 [details]
the patch with the record for ChangeLog

here is the patch with update for ChangeLog (sorry I forgot to add it first time :(
Comment 5 Holger Freyther 2007-09-03 06:56:23 PDT
Thank you for the patch. It was landed in r25350.