Bug 145977 - [WK2] BrowsingContextController.loadData API is leaking Navigation objects
Summary: [WK2] BrowsingContextController.loadData API is leaking Navigation objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-15 09:53 PDT by Chris Dumez
Modified: 2015-06-15 12:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.91 KB, patch)
2015-06-15 11:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-06-15 09:53:19 PDT 
BrowsingContextController.loadData API is leaking Navigation objects. The issue seems to be that WebPageProxy::loadData() creates a Navigation object but does not pass the navigationID to the WebProcess when sending the essages::WebPage::LoadData IPC. As a result, the WebProcess is using 0 as navigationID and we end up creating a new Navigation object later on for the same navigation.

Radar: <rdar://problem/21305706>
Comment 1 Chris Dumez 2015-06-15 11:25:17 PDT 
Created attachment 254885 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-15 12:29:45 PDT 
Comment on attachment 254885 [details]
Patch

Clearing flags on attachment: 254885

Committed r185563: <http://trac.webkit.org/changeset/185563>
Comment 3 WebKit Commit Bot 2015-06-15 12:29:51 PDT 
All reviewed patches have been landed.  Closing bug.