Bug 145813 – Web Inspector: Unable to select the text of an inline error message

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 254593 [details]
Animated GIF of the problem

:(

[Radar WebKit Bug Importer]

<rdar://problem/21306194>

[Nikita Vasilyev]

Created attachment 255714 [details]
Patch

[Nikita Vasilyev]

Created attachment 255715 [details]
[Animated GIF] With the patch applied

[Build Bot]

Comment on attachment 255714 [details]
Patch

Attachment 255714 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5517402502594560

New failing tests:
inspector/debugger/breakpoint-action-eval.html

[Build Bot]

Created attachment 255716 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Timothy Hatcher]

Comment on attachment 255714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255714&action=review

> LayoutTests/TestExpectations:93
> -webkit.org/b/137131 inspector/debugger [ Skip ]
> +#webkit.org/b/137131 inspector/debugger [ Skip ]

Did you mean to include this?

> Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css:84
> +.CodeMirror-linewidget {

We might want a special class name for these in the future if we need other line widgets. Fine for now.

[Nikita Vasilyev]

(In reply to comment #6)
> Comment on attachment 255714 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255714&action=review
> 
> > LayoutTests/TestExpectations:93
> > -webkit.org/b/137131 inspector/debugger [ Skip ]
> > +#webkit.org/b/137131 inspector/debugger [ Skip ]
> 
> Did you mean to include this?

No, I didn't realize `git diff HEAD~1` includes uncommitted changes.

[Nikita Vasilyev]

Created attachment 255793 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 255793 [details]:

transitions/default-timing-function.html bug 138901 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 255793 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 255793 [details]
Patch

Clearing flags on attachment: 255793

Committed r186102: <http://trac.webkit.org/changeset/186102>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.