Bug 145720 – Returned Exception* values need to be initialized to nullptr when no exceptions are thrown.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

For example, see https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r185259%20(52263)/results.html.

The relevant failures are:

Tests that crashed:

+inspector-protocol/debugger/didSampleProbe-multiple-probes.html
+inspector-protocol/debugger/hit-breakpoint-from-console.html
+inspector-protocol/debugger/setBreakpoint-condition.html

Tests that failed text/pixel/audio diff:

inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html
inspector-protocol/debugger/setBreakpoint-actions.html
inspector-protocol/debugger/setBreakpoint-column.html
inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html

These failures only seem to manifest on the Windows Release build test bots.  They don't manifest on the Debug build test bots nor Mac bots.

[Mark Lam]

I skipped these tests for now in r185283: <http://trac.webkit.org/r185283>.

It turns out, that the inspector-protocol/debugger tests were already skipped for platform/mac and inspector-protocol is skipped entirely for Debug build on platform/win.  That may be why we don't see the failures on those bots.

[Mark Lam]

Found the culprit: an un-initialized variable.  This makes me re-consider introducing an opaque type for encapsulating an Exception*. But for now, I'll do the minimum fix.

[Mark Lam]

Created attachment 254407 [details]
the patch.

[WebKit Commit Bot]

Comment on attachment 254407 [details]
the patch.

Clearing flags on attachment: 254407

Committed r185286: <http://trac.webkit.org/changeset/185286>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.