Bug 145675 - Layout tests fullscreen/video-controls-drag.html and media/video-fullscreeen-only-controls.html fail on WK1 and WK2
Summary: Layout tests fullscreen/video-controls-drag.html and media/video-fullscreeen-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-04 17:04 PDT by Said Abou-Hallawa
Modified: 2015-06-05 11:39 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch. (4.97 KB, patch)
2015-06-05 10:17 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-06-04 17:04:36 PDT
These tests began to fail after 

https://trac.webkit.org/changeset/185207
https://trac.webkit.org/changeset/185220
Comment 1 Eric Carlson 2015-06-05 10:17:06 PDT
Created attachment 254360 [details]
Proposed patch.
Comment 2 Alexey Proskuryakov 2015-06-05 10:53:17 PDT
Comment on attachment 254360 [details]
Proposed patch.

Please update test expectations too.
Comment 3 Alexey Proskuryakov 2015-06-05 10:53:55 PDT
Sorry, I didn't notice that you did, was looking for that at the bottom of the patch for some reason.
Comment 4 WebKit Commit Bot 2015-06-05 11:39:37 PDT
Comment on attachment 254360 [details]
Proposed patch.

Clearing flags on attachment: 254360

Committed r185258: <http://trac.webkit.org/changeset/185258>
Comment 5 WebKit Commit Bot 2015-06-05 11:39:42 PDT
All reviewed patches have been landed.  Closing bug.