Bug 145659 - [Cocoa] Add ASSERT to FontPlatformData::ctFont()
Summary: [Cocoa] Add ASSERT to FontPlatformData::ctFont()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-04 14:38 PDT by Myles C. Maxfield
Modified: 2015-06-04 15:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.54 KB, patch)
2015-06-04 14:42 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (5.96 KB, patch)
2015-06-04 14:51 PDT, Myles C. Maxfield 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-06-04 14:38:14 PDT 
[Cocoa] Add ASSERT to FontPlatformData::ctFont()
Comment 1 Myles C. Maxfield 2015-06-04 14:42:10 PDT 
Created attachment 254301 [details]
Patch
Comment 2 Myles C. Maxfield 2015-06-04 14:45:16 PDT 
Comment on attachment 254301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254301&action=review

> Source/WebCore/ChangeLog:10
> +        FontCustomPlatformData and FontPlatformData include, this patch moves the definitions of

This statement is false.
Comment 3 Myles C. Maxfield 2015-06-04 14:51:03 PDT 
Created attachment 254303 [details]
Patch
Comment 4 Dean Jackson 2015-06-04 14:54:34 PDT 
Comment on attachment 254303 [details]
Patch

Personally, I think ENABLE() flags should be restricted to features that can be toggled externally at run time. I suggest you stick with a bare name.
Comment 5 Myles C. Maxfield 2015-06-04 15:00:39 PDT 
Committed r185219: <http://trac.webkit.org/changeset/185219>