Bug 145587 - Subpixel rendering: Composited layer with subpixel gap does not get painted properly when its position changes.
Summary: Subpixel rendering: Composited layer with subpixel gap does not get painted p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-02 19:48 PDT by zalan
Modified: 2015-06-03 08:37 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.08 KB, patch)
2015-06-02 21:10 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (8.13 KB, patch)
2015-06-03 07:45 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-06-02 19:48:14 PDT
When the parent layer moves, the child layer needs to be repainted if the subpixel gap between the layer changes.
Comment 1 zalan 2015-06-02 21:10:00 PDT
Created attachment 254139 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-06-02 21:25:32 PDT
Not for review?
Comment 3 zalan 2015-06-02 21:26:56 PDT
(In reply to comment #2)
> Not for review?
:) Yes for review.
Comment 4 Simon Fraser (smfr) 2015-06-02 21:36:46 PDT
Comment on attachment 254139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254139&action=review

> LayoutTests/compositing/child-layer-with-subpixel-gap-needs-repaint-when-parent-moves.html:16
> +        -webkit-backdrop-filter: invert(1);

Does the test need to use a backdrop filter?
Comment 5 zalan 2015-06-03 07:45:52 PDT
Created attachment 254175 [details]
Patch
Comment 6 zalan 2015-06-03 07:47:20 PDT
(In reply to comment #4)
> Comment on attachment 254139 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254139&action=review
> 
> > LayoutTests/compositing/child-layer-with-subpixel-gap-needs-repaint-when-parent-moves.html:16
> > +        -webkit-backdrop-filter: invert(1);
> 
> Does the test need to use a backdrop filter?
Good point.
Comment 7 WebKit Commit Bot 2015-06-03 08:37:06 PDT
Comment on attachment 254175 [details]
Patch

Clearing flags on attachment: 254175

Committed r185152: <http://trac.webkit.org/changeset/185152>
Comment 8 WebKit Commit Bot 2015-06-03 08:37:10 PDT
All reviewed patches have been landed.  Closing bug.