Bug 145561 - Backdrop filter is pulling in content from behind the window.
Summary: Backdrop filter is pulling in content from behind the window.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-02 12:46 PDT by zalan
Modified: 2015-07-01 15:55 PDT (History)
2 users (show)

See Also:


Attachments
Patch (16.28 KB, patch)
2015-06-02 13:01 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (16.31 KB, patch)
2015-06-02 13:30 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2015-06-02 12:46:38 PDT
Backdrop filter is sized to the parent layer as opposed to the renderer's size.
Comment 1 zalan 2015-06-02 12:47:01 PDT
rdar://problem/20909309
Comment 2 zalan 2015-06-02 13:01:09 PDT
Created attachment 254084 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-06-02 13:10:31 PDT
Comment on attachment 254084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254084&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1885
> +    FloatRect contentBounds(0, 0, m_backdropFiltersRect.width(), m_backdropFiltersRect.height());
> +    m_backdropLayer->setBounds(contentBounds);

This could be m_backdropLayer->setBounds(FloatRect(FloatPoint(), m_backdropFiltersRect.size());

I kinda wish we had FloatRect(FloatSize) for this.
Comment 4 zalan 2015-06-02 13:30:37 PDT
Created attachment 254094 [details]
Patch
Comment 5 WebKit Commit Bot 2015-06-02 14:35:49 PDT
Comment on attachment 254094 [details]
Patch

Clearing flags on attachment: 254094

Committed r185124: <http://trac.webkit.org/changeset/185124>
Comment 6 WebKit Commit Bot 2015-06-02 14:35:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Brent Fulgham 2015-07-01 15:52:56 PDT
This change broke certain compositing features on Windows, primarily the ability to see the debug borders.