RESOLVED FIXED145452
Non-speculative Branch should be fast in the FTL 
https://bugs.webkit.org/show_bug.cgi?id=145452
Summary Non-speculative Branch should be fast in the FTL
Filip Pizlo
Reported 2015-05-28 19:13:31 PDT
There is just no excuse for making C function calls for a branch, since the inline code is probably about the same size as a callsite.
Attachments
the patch (18.90 KB, patch)
2015-05-28 19:19 PDT, Filip Pizlo 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-05-28 19:19:04 PDT
Created attachment 253890 [details] the patch
Andreas Kling
Comment 2 2015-05-29 08:43:12 PDT
Comment on attachment 253890 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=253890&action=review r=me Very nice, I've definitely seen operationConvertJSValueToBoolean sitting around ~2% in various profiles, including Speedometer. > LayoutTests/ChangeLog:11 > + * js/regress/cse-new-array-buffer-expected.txt: Added. > + * js/regress/cse-new-array-buffer.html: Added. > + * js/regress/cse-new-array-expected.txt: Added. > + * js/regress/cse-new-array.html: Added. These files don't belong in this patch.
Filip Pizlo
Comment 3 2015-05-29 11:10:13 PDT
(In reply to comment #2) > Comment on attachment 253890 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253890&action=review > > r=me > > Very nice, I've definitely seen operationConvertJSValueToBoolean sitting > around ~2% in various profiles, including Speedometer. > > > LayoutTests/ChangeLog:11 > > + * js/regress/cse-new-array-buffer-expected.txt: Added. > > + * js/regress/cse-new-array-buffer.html: Added. > > + * js/regress/cse-new-array-expected.txt: Added. > > + * js/regress/cse-new-array.html: Added. > > These files don't belong in this patch. That's true. Do you really want me to land these separately?
Filip Pizlo
Comment 4 2015-05-29 13:27:12 PDT
Landed in http://trac.webkit.org/changeset/185002
Note You need to log in before you can comment on or make changes to this bug.