Bug 145447 - Rename MediaSession to PlatformMediaSession in anticipation of Media Session API
Summary: Rename MediaSession to PlatformMediaSession in anticipation of Media Session API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency tree / graph
 
Reported: 2015-05-28 15:37 PDT by Matt Rajca
Modified: 2015-05-29 14:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (94.39 KB, patch)
2015-05-28 17:05 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (re-based) (94.42 KB, patch)
2015-05-28 17:18 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (fixed GTK build) (95.12 KB, patch)
2015-05-28 17:33 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (fixes Windows and iOS build) (96.75 KB, patch)
2015-05-28 18:21 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-05-28 15:37:17 PDT 
As discussed with Eric Carlson and Jer Noble, we should rename MediaSession to PlatformMediaSession to reserve "media session" for the Media Session API (bug 145411).
Comment 1 Radar WebKit Bug Importer 2015-05-28 15:38:54 PDT 
<rdar://problem/21149514>
Comment 2 Matt Rajca 2015-05-28 17:05:14 PDT 
Created attachment 253879 [details]
Patch
Comment 3 Matt Rajca 2015-05-28 17:18:11 PDT 
Created attachment 253881 [details]
Patch (re-based)
Comment 4 WebKit Commit Bot 2015-05-28 17:20:58 PDT 
Attachment 253881 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/PlatformMediaSession.cpp:44:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Matt Rajca 2015-05-28 17:33:11 PDT 
Created attachment 253883 [details]
Patch (fixed GTK build)
Comment 6 WebKit Commit Bot 2015-05-28 17:36:17 PDT 
Attachment 253883 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/PlatformMediaSession.cpp:44:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Matt Rajca 2015-05-28 18:21:31 PDT 
Created attachment 253885 [details]
Patch (fixes Windows and iOS build)
Comment 8 WebKit Commit Bot 2015-05-28 18:23:06 PDT 
Attachment 253885 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/PlatformMediaSession.cpp:44:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Commit Bot 2015-05-29 14:53:51 PDT 
Comment on attachment 253885 [details]
Patch (fixes Windows and iOS build)

Clearing flags on attachment: 253885

Committed r185006: <http://trac.webkit.org/changeset/185006>
Comment 10 WebKit Commit Bot 2015-05-29 14:53:55 PDT 
All reviewed patches have been landed.  Closing bug.