Bug 145340 – Handle case where -startOptimizedFullscreen fails.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

Handle case where -startOptimizedFullscreen fails.

[Jeremy Jones]

rdar://problem/19416954

[Jeremy Jones]

Created attachment 253638 [details]
Patch

[Eric Carlson]

Comment on attachment 253638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253638&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1291
> +    RefPtr<WebVideoFullscreenInterfaceAVKit> strongThis(this);
> +    WebThreadRun([strongThis, this] {
> +        if (hasMode(HTMLMediaElementEnums::VideoFullscreenModeStandard))
> +            return;
> +
> +        m_exitCompleted = true;

This will leave m_exitCompleted set to true if hasMode(HTMLMediaElementEnums::VideoFullscreenModeStandard). Will this cause problems later?

[Jeremy Jones]

(In reply to comment #3)
> Comment on attachment 253638 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253638&action=review
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1291
> > +    RefPtr<WebVideoFullscreenInterfaceAVKit> strongThis(this);
> > +    WebThreadRun([strongThis, this] {
> > +        if (hasMode(HTMLMediaElementEnums::VideoFullscreenModeStandard))
> > +            return;
> > +
> > +        m_exitCompleted = true;
> 
> This will leave m_exitCompleted set to true if
> hasMode(HTMLMediaElementEnums::VideoFullscreenModeStandard). Will this cause
> problems later?

I think you mean leave it false. And that is exactly what we want. If we still have standard mode, then we have not completely exited fullscreen.

Also, the build error is SPI that I'll add to AVKitSPI.h

[Jeremy Jones]

Created attachment 253658 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 253658 [details]
Patch

Clearing flags on attachment: 253658

Committed r184907: <http://trac.webkit.org/changeset/184907>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.