Bug 145270 - Regression(r179293): We no longer call destroyDecodedData() on CachedResources on memory pressure
Summary: Regression(r179293): We no longer call destroyDecodedData() on CachedResource...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 140964
  Show dependency tree / graph
 
Reported: 2015-05-21 10:25 PDT by Chris Dumez
Modified: 2015-05-21 10:45 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.72 KB, patch)
2015-05-21 10:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-05-21 10:25:42 PDT 
We no longer call destroyDecodedData() on CachedResources on memory pressure after r179293. In r179293, we started calling MemoryCache::evictResources() on memory pressure instead of MemoryCache::pruneToPercentage(0).
However, unlike MemoryCache::pruneToPercentage(), it appears MemoryCache::evictResources() removes the CachedResources from the memory cache without calling destroyDecodedData() on them. This caused a regression on Membuster.

Radar: <rdar://problem/20734901>
Comment 1 Chris Dumez 2015-05-21 10:39:39 PDT 
Created attachment 253530 [details]
Patch
Comment 2 Andreas Kling 2015-05-21 10:42:38 PDT 
Comment on attachment 253530 [details]
Patch

Fantastic job hunting this down!! r=me
Comment 3 Chris Dumez 2015-05-21 10:45:29 PDT 
Comment on attachment 253530 [details]
Patch

Clearing flags on attachment: 253530

Committed r184720: <http://trac.webkit.org/changeset/184720>
Comment 4 Chris Dumez 2015-05-21 10:45:34 PDT 
All reviewed patches have been landed.  Closing bug.