Bug 145171 – [GTK] Layout Test fast/events/tabindex-focus-blur-all.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Marcos Chavarría Teijeiro (irc: chavaone)]

The fast/events/tabindex-focus-blur-all.html layout test is flaky on GTK+. It timeouts sometimes.

[Fujii Hironori]

Recently, this test case results in crash, no timeout.

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r218352%20(1761)/fast/events/tabindex-focus-blur-all-crash-log.txt

> Thread 1 (Thread 0x7f5a137fe700 (LWP 6602)):
> #0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
> #1  0x00007f5c00c423fa in __GI_abort () at abort.c:89
> #2  0x00007f5c05321595 in g_assertion_message () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gtestutils.c:2433
> #3  0x00007f5c0532161a in g_assertion_message_expr () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gtestutils.c:2456
> #4  0x00007f5c06253e77 in gst_gl_shader_attach_unlocked () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglshader.c:539
> #5  0x00007f5c06253f27 in gst_gl_shader_attach () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglshader.c:577
> #6  0x00007f5c0625420b in gst_gl_shader_compile_attach_stage () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglshader.c:607
> #7  0x00007f5c0625a267 in _create_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcolorconvert.c:1934
> #8  _init_convert () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcolorconvert.c:2028
> #9  _do_convert () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcolorconvert.c:2368
> #10 0x00007f5c0625e683 in _run_message_sync () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglwindow.c:601
> #11 0x00007f5c0625e622 in _run_message_async () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglwindow.c:668
> #12 0x00007f5c052fb5ca in g_main_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3212
> #13 g_main_context_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3865
> #14 0x00007f5c052fb948 in g_main_context_iterate () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3938
> #15 0x00007f5c052fbc62 in g_main_loop_run () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:4134
> #16 0x00007f5c0625e6f5 in gst_gl_window_default_run () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglwindow.c:527
> #17 0x00007f5c0624795c in gst_gl_context_create_thread () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcontext.c:1273
> #18 0x00007f5c05322315 in g_thread_proxy () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gthread.c:784
> #19 0x00007f5c01e93494 in start_thread (arg=0x7f5a137fe700) at pthread_create.c:333
> #20 0x00007f5c00cf693f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97


https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r218317%20(1748)/fast/events/tabindex-focus-blur-all-crash-log.txt

> Thread 1 (Thread 0x7effdeffd700 (LWP 10479)):
> #0  0x00007f00e451592f in exec_node_remove () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/Mesa/src/glsl/list.h:170
> #1  _ZN9exec_node6removeEv () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/Mesa/src/glsl/list.h:248
> #2  _Z31optimize_dead_builtin_variablesP9exec_list16ir_variable_mode () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/Mesa/src/glsl/opt_dead_builtin_variables.cpp:79
> #3  0x00007f00e44d6cfb in _mesa_glsl_compile_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/Mesa/src/glsl/glsl_parser_extras.cpp:1647
> #4  0x00007f00e43a2bba in compile_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/Mesa/src/mesa/main/shaderapi.c:980
> #5  0x00007f016575f3d2 in _compile_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglslstage.c:486
> #6  0x00007f016574e990 in gst_gl_context_thread_add () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcontext.c:1537
> #7  0x00007f016575fe07 in gst_glsl_stage_compile () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglslstage.c:542
> #8  0x00007f016575c1eb in gst_gl_shader_compile_attach_stage () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglshader.c:603
> #9  0x00007f016576203f in _create_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcolorconvert.c:1830
> #10 _init_convert () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcolorconvert.c:2028
> #11 _do_convert () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcolorconvert.c:2368
> #12 0x00007f0165766683 in _run_message_sync () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglwindow.c:601
> #13 0x00007f0165766622 in _run_message_async () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglwindow.c:668
> #14 0x00007f01648035ca in g_main_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3212
> #15 g_main_context_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3865
> #16 0x00007f0164803948 in g_main_context_iterate () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3938
> #17 0x00007f0164803c62 in g_main_loop_run () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:4134
> #18 0x00007f01657666f5 in gst_gl_window_default_run () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglwindow.c:527
> #19 0x00007f016574f95c in gst_gl_context_create_thread () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcontext.c:1273
> #20 0x00007f016482a315 in g_thread_proxy () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gthread.c:784
> #21 0x00007f016139b494 in start_thread (arg=0x7effdeffd700) at pthread_create.c:333
> #22 0x00007f01601fe93f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97


https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r218190%20(1710)/fast/events/tabindex-focus-blur-all-crash-log.txt

> Thread 1 (Thread 0x7fadd7fff700 (LWP 28881)):
> #0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
> #1  0x00007faf6a0b73fa in __GI_abort () at abort.c:89
> #2  0x00007faf6e796595 in g_assertion_message () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gtestutils.c:2433
> #3  0x00007faf6e79661a in g_assertion_message_expr () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gtestutils.c:2456
> #4  0x00007faf6f6c8b59 in gst_gl_shader_detach_unlocked () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglshader.c:462
> #5  0x00007faf6f6c975f in gst_gl_shader_release_unlocked () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglshader.c:738
> #6  0x00007faf6f6c97cf in _cleanup_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglshader.c:103
> #7  0x00007faf6f6bb990 in gst_gl_context_thread_add () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcontext.c:1537
> #8  0x00007faf6f6c8514 in gst_gl_shader_finalize () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglshader.c:128
> #9  0x00007faf6e84f02a in g_object_unref () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/gobject/gobject.c:3185
> #10 0x00007faf6f6d0379 in _create_shader () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcolorconvert.c:1950
> #11 _init_convert () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcolorconvert.c:2028
> #12 _do_convert () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcolorconvert.c:2368
> #13 0x00007faf6f6d3683 in _run_message_sync () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglwindow.c:601
> #14 0x00007faf6f6d3622 in _run_message_async () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglwindow.c:668
> #15 0x00007faf6e7705ca in g_main_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3212
> #16 g_main_context_dispatch () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3865
> #17 0x00007faf6e770948 in g_main_context_iterate () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:3938
> #18 0x00007faf6e770c62 in g_main_loop_run () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmain.c:4134
> #19 0x00007faf6f6d36f5 in gst_gl_window_default_run () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglwindow.c:527
> #20 0x00007faf6f6bc95c in gst_gl_context_create_thread () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcontext.c:1273
> #21 0x00007faf6e797315 in g_thread_proxy () at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gthread.c:784
> #22 0x00007faf6b308494 in start_thread (arg=0x7fadd7fff700) at pthread_create.c:333
> #23 0x00007faf6a16b93f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

[Fujii Hironori]

I see another type of crash in my linux box.

> Thread 1 (Thread 0x7ffefffff700 (LWP 81045)):
> #0  _g_log_abort () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmessages.c:549
> #1  0x00007fffeeeb38d1 in g_log_writer_default () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmessages.c:2613
> #2  0x00007fffeeeb1e3c in g_log_structured_array () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmessages.c:1933
> #3  0x00007fffeeeb2139 in g_log_structured () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gmessages.c:1760
> #4  0x00007fffeab0a60e in _gdk_x11_display_error_event () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/gtk+-3.22.11/gdk/x11/gdkdisplay-x11.c:2579
> #5  0x00007fffeab17833 in gdk_x_error () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/gtk+-3.22.11/gdk/x11/gdkmain-x11.c:307
> #6  0x00007fffeddc3c8d in _XError () from /usr/lib/x86_64-linux-gnu/libX11.so.6
> #7  0x00007fffeddc0bb7 in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6
> #8  0x00007fffeddc0c75 in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6
> #9  0x00007fffeddc1b88 in _XReply () from /usr/lib/x86_64-linux-gnu/libX11.so.6
> #10 0x00007fffedda66be in XGetGeometry () from /usr/lib/x86_64-linux-gnu/libX11.so.6
> #11 0x00007ffff2b2bc49 in swrastGetDrawableInfo () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/Mesa/src/glx/drisw_glx.c:108
> #12 0x00007fff74f421d7 in get_drawable_info () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/Mesa/src/gallium/state_trackers/dri/drisw.c:59
> #13 drisw_update_drawable_info () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/Mesa/src/gallium/state_trackers/dri/drisw.c:104
> #14 0x00007fff74f410d5 in dri_st_framebuffer_validate () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/Mesa/src/gallium/state_trackers/dri/dri_drawable.c:81
> #15 0x00007fff74e7380e in st_framebuffer_validate () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/Mesa/src/mesa/state_tracker/st_manager.c:200
> #16 0x00007fff74e74af0 in st_api_make_current () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/Mesa/src/mesa/state_tracker/st_manager.c:774
> #17 0x00007fff74f40bc1 in dri_make_current () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/Mesa/src/gallium/state_trackers/dri/dri_context.c:245
> #18 0x00007fff74f3fbc6 in driBindContext () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/Mesa/src/mesa/drivers/dri/common/dri_util.c:530
> #19 0x00007ffff2b2ba7a in drisw_bind_context () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/Mesa/src/glx/drisw_glx.c:253
> #20 0x00007ffff2b056a4 in MakeContextCurrent () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/Mesa/src/glx/glxcurrent.c:228
> #21 0x00007ffff081074a in gst_gl_context_glx_activate () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/x11/gstglcontext_glx.c:459
> #22 0x00007ffff07e9e82 in gst_gl_context_activate () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcontext.c:729
> #23 0x00007ffff07eb64e in gst_gl_context_create_thread () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/gst-plugins-bad-1.10.4/gst-libs/gst/gl/gstglcontext.c:1217
> #24 0x00007fffeeed3315 in g_thread_proxy () at /home/fujii/work/webkit/ga/WebKitBuild/DependenciesGTK/Source/glib-2.52.1/glib/gthread.c:784
> #25 0x00007fffecd6e6da in start_thread (arg=0x7ffefffff700) at pthread_create.c:456
> #26 0x00007fffeb9c117f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:105

[Fujii Hironori]

Created attachment 313060 [details]
gardening patch

[Fujii Hironori]

Created attachment 313061 [details]
gardening patch

[WebKit Commit Bot]

Comment on attachment 313061 [details]
gardening patch

Rejecting attachment 313061 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 313061, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/3940296

[Fujii Hironori]

Created attachment 313065 [details]
gardening patch

[WebKit Commit Bot]

Comment on attachment 313065 [details]
gardening patch

Rejecting attachment 313065 [details] from commit-queue.

New failing tests:
inspector/canvas/create-canvas-contexts.html
Full output: http://webkit-queues.webkit.org/results/3940937

[WebKit Commit Bot]

Created attachment 313070 [details]
Archive of layout-test-results from webkit-cq-03 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[WebKit Commit Bot]

Comment on attachment 313065 [details]
gardening patch

Clearing flags on attachment: 313065

Committed r218394: <http://trac.webkit.org/changeset/218394>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Diego Pino]

The test(s) filed under this bug have been consistently passing for the last 4000 revisions. Marking bug as fixed.

Committed r263254: <https://trac.webkit.org/changeset/263254>

[Radar WebKit Bug Importer]

<rdar://problem/64520213>