WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145027
[Content Extensions] Fail to load old content extension files
https://bugs.webkit.org/show_bug.cgi?id=145027
Summary
[Content Extensions] Fail to load old content extension files
Alex Christensen
Reported
2015-05-14 16:12:40 PDT
Old files are causing crashes. Let's fail to load them.
Attachments
Patch
(3.54 KB, patch)
2015-05-14 16:14 PDT
,
Alex Christensen
eric.carlson
: review+
achristensen
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2015-05-14 16:14:10 PDT
Created
attachment 253153
[details]
Patch
Eric Carlson
Comment 2
2015-05-15 09:37:25 PDT
Comment on
attachment 253153
[details]
Patch Thank you Alex!
Alex Christensen
Comment 3
2015-05-15 10:03:30 PDT
Comment on
attachment 253153
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=253153&action=review
> Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.cpp:157 > + if (metaData.version != UserContentExtensionStore::CurrentContentExtensionFileVersion) > + return false;
Instead of returning false here, I'm going to check the metaData.version after openAndMapContentExtension returns and call the completionHandler with a new type of error (Error::VersionMismatch or something).
Alex Christensen
Comment 4
2015-05-15 13:51:04 PDT
http://trac.webkit.org/changeset/184413
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug