WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
144985
String.prototype.split() should create efficient substrings.
https://bugs.webkit.org/show_bug.cgi?id=144985
Summary
String.prototype.split() should create efficient substrings.
Andreas Kling
Reported
2015-05-13 20:18:13 PDT
<
rdar://problem/20949344
> String.prototype.split() should create JSStrings using the lazy substring optimization.
Attachments
Patch
(7.43 KB, patch)
2015-05-13 20:21 PDT
,
Andreas Kling
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2015-05-13 20:21:33 PDT
Created
attachment 253088
[details]
Patch
Geoffrey Garen
Comment 2
2015-05-14 11:10:03 PDT
Comment on
attachment 253088
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=253088&action=review
r=me
> Source/JavaScriptCore/runtime/StringPrototype.cpp:179 > +static inline JSString* jsSubstringWithSharing(ExecState* exec, JSValue originalValue, const String& string, unsigned offset, unsigned length)
I would just call this jsSubstring.
Andreas Kling
Comment 3
2015-05-14 12:08:56 PDT
Committed
r184346
: <
http://trac.webkit.org/changeset/184346
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug