Bug 144832 – Page overlay action context override should indicate the source of the request

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Page overlay action context override should indicate the source of the request

[Tim Horton]

Created attachment 252785 [details]
Patch

[WebKit Commit Bot]

Attachment 252785 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPageOverlay.cpp:123:  Declaration has space between type name and * in DDActionContext *WebPageOverlay  [whitespace/declaration] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 252785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252785&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:47
> +typedef uint32_t _WKBundlePageOverlayActionContextRequestType;

Not sure I understand the rationale behind the leading underscore here.

[Tim Horton]

(In reply to comment #3)
> Comment on attachment 252785 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252785&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:47
> > +typedef uint32_t _WKBundlePageOverlayActionContextRequestType;
> 
> Not sure I understand the rationale behind the leading underscore here.

I think it's to avoid naming conflicts with potential future Modern API enum names (the enum values are similarly uniqified by the leading 'k'). Anders points out that this doesn't help if we want to add Modern SPI (because that would have a leading underscore as well), but we don't really have a plan for that yet.

https://trac.webkit.org/changeset/184106