Flip the direction of the fence in scaleViewAndUpdateGeometryFenced
Created attachment 252740 [details] Patch
Attachment 252740 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:2251: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:656: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 252740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=252740&action=review > Source/WebKit2/ChangeLog:20 > + Note that you must setFencePort() with this port if you want the LayerHostingContext's > + CAContext to block on it! This comment will go unnoticed here; it should be in the code. > Source/WebKit2/UIProcess/WebPageProxy.h:1321 > + void machSendRightCallback(const WebCore::MachSendRight&, uint64_t); So sad we have all these untyped uint64_t. > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:89 > + virtual void replyWithFenceAfterNextFlush(uint64_t callbackID) override; If uint64_t were typed you wouldn't have to explain what it was. > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:152 > + Vector<uint64_t> m_fenceCallbacksForAfterNextFlush; :| > Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:335 > + for (uint64_t callbackID : m_fenceCallbacksForAfterNextFlush) auto?
http://trac.webkit.org/changeset/184011
http://trac.webkit.org/changeset/184012
http://trac.webkit.org/changeset/184014
http://trac.webkit.org/changeset/184016