Bug 144758 - Release assert in com.apple.WebKit.WebContent under JavaScriptCore: JSC::JSONProtoFuncStringify
Summary: Release assert in com.apple.WebKit.WebContent under JavaScriptCore: JSC::JSON...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-07 14:16 PDT by Geoffrey Garen
Modified: 2015-05-07 16:30 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.33 KB, patch)
2015-05-07 14:20 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (167.78 KB, application/zip)
2015-05-07 14:50 PDT, Build Bot 		no flags Details
Patch (7.39 KB, patch)
2015-05-07 15:18 PDT, Geoffrey Garen 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-05-07 14:16:08 PDT 
Release assert in com.apple.WebKit.WebContent under JavaScriptCore: JSC::JSONProtoFuncStringify
Comment 1 Geoffrey Garen 2015-05-07 14:16:42 PDT 
<rdar://problem/20486283>
Comment 2 Geoffrey Garen 2015-05-07 14:20:27 PDT 
Created attachment 252625 [details]
Patch
Comment 3 Andreas Kling 2015-05-07 14:35:24 PDT 
Comment on attachment 252625 [details]
Patch

r=me
Comment 4 Build Bot 2015-05-07 14:50:00 PDT 
Comment on attachment 252625 [details]
Patch

Attachment 252625 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5179393798307840

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2015-05-07 14:50:02 PDT 
Created attachment 252632 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Geoffrey Garen 2015-05-07 15:07:44 PDT 
Comment on attachment 252625 [details]
Patch

Broken :(.
Comment 7 Geoffrey Garen 2015-05-07 15:18:01 PDT 
Created attachment 252635 [details]
Patch
Comment 8 Geoffrey Garen 2015-05-07 15:24:39 PDT 
Comment on attachment 252635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252635&action=review

> Source/bmalloc/bmalloc/StaticMutex.cpp:34
> -        std::this_thread::yield();
> +        { }

Oops! Will revert this part.
Comment 9 Andreas Kling 2015-05-07 16:21:28 PDT 
Comment on attachment 252635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252635&action=review

Damn, too much itchy in the trigger finger last time. :|

>> Source/bmalloc/bmalloc/StaticMutex.cpp:34
>> +        { }
> 
> Oops! Will revert this part.

k
Comment 10 Geoffrey Garen 2015-05-07 16:30:34 PDT 
Committed r183959: <http://trac.webkit.org/changeset/183959>