Bug 144745 – [WK2] Remove Windows cruft

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

There is no port supports WebKit2 on Windows, but 
there are some Windows specific cruft there.

[Csaba Osztrogonác]

Created attachment 252593 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 252593 [details]
Patch

Clearing flags on attachment: 252593

Committed r183931: <http://trac.webkit.org/changeset/183931>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Milan Crha]

(In reply to comment #0)
> There is no port supports WebKit2 on Windows, but 
> there are some Windows specific cruft there.

Do you mean there is also no plan to do it in the future? There is some opposite effort for 2.4.9 (bug #133028), but also for WebKit2 (bug #137488). Were you aware of these efforts?

[Csaba Osztrogonác]

(In reply to comment #4)
> (In reply to comment #0)
> > There is no port supports WebKit2 on Windows, but 
> > there are some Windows specific cruft there.
> 
> Do you mean there is also no plan to do it in the future? There is some
> opposite effort for 2.4.9 (bug #133028), but also for WebKit2 (bug #137488).
> Were you aware of these efforts?

I don't know if anyone has plan to support WebKit2 on Windows
in the future on WebKit trunk or on the old 2.4 GTK branch.
Carlos, do you have plan to do it?

But it is much bigger task than the title of bug137488 says. It isn't a
buildfix at all, or adding back something, GTK didn't have WebKit2 port
on Windows ever and now the whole Windows IPC implementation is missing
and I can't see if anybody started to implement it.

I don't think if this change is an opposite of the effort to fix 2.4 on Windows.
It was maybe the last piece of Windows cruft in WebKit2 directory from the Qt
era. Of course, if you would like to add Windows support for Webkit2 once, maybe
you will need this code or something similar. But I can't see any reason to keep
crufts in WebKit trunk just because maybe somebody will need it in the far future
for a not well maintained configuration.

[Carlos Garcia Campos]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #0)
> > > There is no port supports WebKit2 on Windows, but 
> > > there are some Windows specific cruft there.
> > 
> > Do you mean there is also no plan to do it in the future? There is some
> > opposite effort for 2.4.9 (bug #133028), but also for WebKit2 (bug #137488).
> > Were you aware of these efforts?
> 
> I don't know if anyone has plan to support WebKit2 on Windows
> in the future on WebKit trunk or on the old 2.4 GTK branch.
> Carlos, do you have plan to do it?

I have plans to *fix* the windows support in 2.4 branch for WebKit1 *only*.

> But it is much bigger task than the title of bug137488 says. It isn't a
> buildfix at all, or adding back something, GTK didn't have WebKit2 port
> on Windows ever and now the whole Windows IPC implementation is missing
> and I can't see if anybody started to implement it.

Right, some people showed interest in adding windows support to WebKit2 for the GTK+ port, like Milan indeed, but for now I think all the efforts are for WebKit1 in 2.4 branch, because in that case problems are mostly build issues.

> I don't think if this change is an opposite of the effort to fix 2.4 on
> Windows.

It's not.

> It was maybe the last piece of Windows cruft in WebKit2 directory from the Qt
> era. Of course, if you would like to add Windows support for Webkit2 once,
> maybe
> you will need this code or something similar. But I can't see any reason to
> keep
> crufts in WebKit trunk just because maybe somebody will need it in the far
> future
> for a not well maintained configuration.

I agree. I would love to see windows supported in WebKit2 again, but since it's a lot of work, I think it should be done in a branch and start merging patches *only* when there's a minimal working implementation, keeping trunk clean in the meantime.

[Milan Crha]

Okay, thanks for the clarification. I know that the 2.4.x effort aims into the WebKit1 windows build only, I'm not going to even try to build WebKit2 in 2.4.x under windows, that would be plain waste of time.

My only interest is that the Evolution (GNOME mail/calendar/... client) plans to port to WebKit2, which would eventually break (also unsupported, but doable) Windows builds of Evolution. Using WebKit2 would just shut the door for anyone willing to finish the Windows port of Evolution, due to WebKit2 being unsupported there. What I try here is to use as much of the gtk+ code as possible in the WebKit2, to avoid any Windows specific code in the WebKit, when it's already available in the gtk+.

As was mentioned couple times, it's a long run, and I do it only in my free time, which I kind of lack recently, thus it's still just "nice to have".