Bug 144708 - RenderLayer::currentTransform computes a pixel snapped rect it doesn't use
Summary: RenderLayer::currentTransform computes a pixel snapped rect it doesn't use
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-06 13:52 PDT by Dave Hyatt
Modified: 2015-05-06 14:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.61 KB, patch)
2015-05-06 13:55 PDT, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2015-05-06 13:52:36 PDT 
RenderLayer::currentTransform computes a pixel snapped rect it doesn't use. Make sure to only compute the pixel snapped rect for the rare cases where we actually need it.
Comment 1 Dave Hyatt 2015-05-06 13:55:52 PDT 
Created attachment 252518 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-05-06 13:58:47 PDT 
Comment on attachment 252518 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252518&action=review

> Source/WebCore/rendering/RenderLayer.cpp:977
> +    // Note that pixelSnappedBorderRect is only computed inside the if statements, since
> +    // the common case is that neither of these if conditions is matched.

I don't think this comment is necessary.
Comment 3 Dave Hyatt 2015-05-06 14:01:40 PDT 
Fixed in r183887.