Bug 144684 - Rename URL::copy() to URL::isolatedCopy() to match String.
Summary: Rename URL::copy() to URL::isolatedCopy() to match String.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sungmann Cho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-06 06:25 PDT by Sungmann Cho
Modified: 2015-05-06 17:29 PDT (History)
1 user (show)

See Also:

Attachments
Patch (12.14 KB, patch)
2015-05-06 07:03 PDT, Sungmann Cho 		no flags Details | Formatted Diff | Diff
Patch (12.22 KB, patch)
2015-05-06 15:05 PDT, Sungmann Cho 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sungmann Cho 2015-05-06 06:25:33 PDT 
SSIA
Comment 1 Sungmann Cho 2015-05-06 07:03:15 PDT 
Created attachment 252471 [details]
Patch
Comment 2 Darin Adler 2015-05-06 09:26:10 PDT 
Comment on attachment 252471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252471&action=review

> Source/WebCore/platform/URL.h:86
>      // no other reason to ever prefer copy() over plain old assignment.

Should fix this comment too.
Comment 3 Sungmann Cho 2015-05-06 15:05:14 PDT 
Created attachment 252523 [details]
Patch
Comment 4 Sungmann Cho 2015-05-06 15:05:43 PDT 
Addressed darin's comments.
Comment 5 WebKit Commit Bot 2015-05-06 17:29:44 PDT 
Comment on attachment 252523 [details]
Patch

Clearing flags on attachment: 252523

Committed r183901: <http://trac.webkit.org/changeset/183901>
Comment 6 WebKit Commit Bot 2015-05-06 17:29:47 PDT 
All reviewed patches have been landed.  Closing bug.