144673 – LayoutTests/fast/forms/button-line-height.html is broken on non-Mac/non-iOS ports

Bug 144673 - LayoutTests/fast/forms/button-line-height.html is broken on non-Mac/non-iOS ports

Summary: LayoutTests/fast/forms/button-line-height.html is broken on non-Mac/non-iOS p...

Status:	NEW

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:

Duplicates (1):	144572 (view as bug list)
Depends on:
Blocks:

Reported:	2015-05-05 23:44 PDT by Nikita Vasilyev
Modified:	2015-05-06 10:47 PDT (History)
CC List:	1 user (show)

See Also:	144234

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nikita Vasilyev 2015-05-05 23:44:13 PDT

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&showExpectations=true&tests=fast%2Fforms%2Fbutton-line-height.html

Comment 1 Nikita Vasilyev 2015-05-06 00:18:15 PDT

Set to skip it in http://trac.webkit.org/changeset/183862 for now.

Comment 2 Alexey Proskuryakov 2015-05-06 10:05:47 PDT

It's better to mark this test as failing, not to skip it. This way, we still get some coverage in case it starts to crash, and also we have dashboard history to tell us if the test started to pass at some moment.

Generally, we skip when a test crashes very often, times out, or when it breaks subsequent tests by leaking state in some way.

Updated the expectation in <http://trac.webkit.org/r183873>.

Comment 3 Martin Robinson 2015-05-06 10:47:04 PDT

*** Bug 144572 has been marked as a duplicate of this bug. ***