Bug 144615 - Small cleanup in RenderText::computePreferredLogicalWidths()
Summary: Small cleanup in RenderText::computePreferredLogicalWidths()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-04 18:11 PDT by Myles C. Maxfield
Modified: 2015-05-05 00:50 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.89 KB, patch)
2015-05-04 18:13 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch for landing (6.00 KB, patch)
2015-05-04 19:58 PDT, Myles C. Maxfield 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-05-04 18:11:58 PDT 
Small cleanup in RenderText::computePreferredLogicalWidths()
Comment 1 Myles C. Maxfield 2015-05-04 18:13:03 PDT 
Created attachment 252359 [details]
Patch
Comment 2 Myles C. Maxfield 2015-05-04 18:18:17 PDT 
Comment on attachment 252359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252359&action=review

> Source/WebCore/rendering/RenderText.cpp:907
> +        glyphOverflow.left = firstGlyphLeftOverflow.value();

could use valueOr()
Comment 3 Myles C. Maxfield 2015-05-04 18:41:51 PDT 
Comment on attachment 252359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252359&action=review

> Source/WebCore/rendering/RenderText.cpp:867
>              currMinWidth = 0;

Unnecessary

> Source/WebCore/rendering/RenderText.cpp:877
>              currMinWidth = 0;

Unnecessary
Comment 4 Myles C. Maxfield 2015-05-04 19:58:29 PDT 
Created attachment 252365 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2015-05-04 20:52:27 PDT 
Comment on attachment 252365 [details]
Patch for landing

Rejecting attachment 252365 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 252365, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5014590802886656
Comment 6 Myles C. Maxfield 2015-05-05 00:50:32 PDT 
Committed r183799: <http://trac.webkit.org/changeset/183799>