Bug 144568 - Network Cache: Support time based cache clearing
Summary: Network Cache: Support time based cache clearing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-05-04 06:06 PDT by Antti Koivisto
Modified: 2015-05-04 11:53 PDT (History)
3 users (show)

See Also:


Attachments
patch (10.61 KB, patch)
2015-05-04 08:39 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-05-04 06:06:08 PDT
<rdar://problem/19769820>
Comment 1 Antti Koivisto 2015-05-04 08:39:40 PDT
Created attachment 252311 [details]
patch
Comment 2 WebKit Commit Bot 2015-05-04 08:41:27 PDT
Attachment 252311 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:718:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:65:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:537:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:158:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:176:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2015-05-04 11:03:59 PDT
Comment on attachment 252311 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252311&action=review

r=me

> Source/WebKit2/ChangeLog:25
> +        (WebKit::clearNSURCache):

Should be called clearNSURLCache. :)
Comment 4 Antti Koivisto 2015-05-04 11:53:28 PDT
https://trac.webkit.org/r183755