--version-script isn't supported by the OSX linker. The build fails with this error: Linking CXX shared library ../../lib/libwebkit2gtk-4.0.dylib ld: unknown option: --version-script clang: error: linker command failed with exit code 1 (use -v to see invocation)
Created attachment 252289 [details] Patch This adds the --version-script option only on Linux.
Attachment 252289 [details] did not pass style-queue: Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
What about other unix os like FreeBSD, is --version-script linux specific?
--version-script is supported by GNU LD and the Solaris linker, according to https://www.gnu.org/software/gnulib/manual/html_node/LD-Version-Scripts.html
Created attachment 252687 [details] Patch
Above is a patch which turns it around; only omits the option on Darwin.
Is it possible to collect all of the OS X specific changes in a branch and them merge them when everything is functional?
I assume I don't have privileges to create/commit to a branch in the WebKit repository. Is that correct? Is a GitHub branch OK? If you want to see the patches all together, they're here in a jhbuild module in this work-in-progress commit: https://github.com/ptomato/gtk-osx-build/commit/0a09d53e4d9bf7ae49b19f9e2adea9da9fdf8472 This _should_ yield a working version of WebKitGTK 2.8.0 on OSX.
As discussed on #126492, there's also https://github.com/ptomato/webkit/pull/2
Comment on attachment 252687 [details] Patch This patch seems okay, but the commit message is a bit inaccurate. !Darwin doesn't necessary imply Linux.
Comment on attachment 252687 [details] Patch Clearing flags on attachment: 252687 Committed r190856: <http://trac.webkit.org/changeset/190856>
All reviewed patches have been landed. Closing bug.