Bug 144548 – [Mac] Show wireless playback placard even when an element has custom controls

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Show wireless playback placard even when an element has custom controls

[Eric Carlson]

<rdar://problem/20785777>

[Eric Carlson]

Created attachment 252275 [details]
Proposed patch.

[WebKit Commit Bot]

Attachment 252275 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 252275 [details]
Proposed patch.

Attachment 252275 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6630518024044544

New failing tests:
media/track/track-cue-rendering-horizontal.html

[Build Bot]

Created attachment 252276 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Eric Carlson]

Created attachment 252278 [details]
Updated patch.

[Build Bot]

Comment on attachment 252275 [details]
Proposed patch.

Attachment 252275 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6676395254087680

New failing tests:
media/track/track-cue-rendering-horizontal.html
http/tests/contentextensions/text-track-blocked.html

[Build Bot]

Created attachment 252279 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[WebKit Commit Bot]

Attachment 252278 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 252278 [details]
Updated patch.

Attachment 252278 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4885652998979584

New failing tests:
media/track/track-cue-rendering-horizontal.html
http/tests/contentextensions/text-track-blocked.html

[Build Bot]

Created attachment 252281 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 252278 [details]
Updated patch.

Attachment 252278 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5245111898210304

New failing tests:
media/track/track-cue-rendering-horizontal.html

[Build Bot]

Created attachment 252282 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Eric Carlson]

Created attachment 252310 [details]
Updated patch.

[Brent Fulgham]

Comment on attachment 252310 [details]
Updated patch.

r=me.

[WebKit Commit Bot]

Comment on attachment 252310 [details]
Updated patch.

Clearing flags on attachment: 252310

Committed r183751: <http://trac.webkit.org/changeset/183751>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.