Bug 144493 - Stop using deprecated AVKit SPI for enter and exit fullscreen.
Summary: Stop using deprecated AVKit SPI for enter and exit fullscreen.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-01 10:38 PDT by Jeremy Jones
Modified: 2015-05-01 14:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.89 KB, patch)
2015-05-01 10:42 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2015-05-01 10:38:29 PDT
Stop using deprecated AVKit SPI for enter and exit fullscreen.
Comment 1 Jeremy Jones 2015-05-01 10:41:06 PDT
rdar://problem/20733676
Comment 2 Jeremy Jones 2015-05-01 10:42:20 PDT
Created attachment 252157 [details]
Patch
Comment 3 WebKit Commit Bot 2015-05-01 10:44:17 PDT
Attachment 252157 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1043:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:1098:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2015-05-01 14:19:22 PDT
Comment on attachment 252157 [details]
Patch

Clearing flags on attachment: 252157

Committed r183690: <http://trac.webkit.org/changeset/183690>
Comment 5 WebKit Commit Bot 2015-05-01 14:19:25 PDT
All reviewed patches have been landed.  Closing bug.