Bug 144454 - USE(...) macro should expect unprefixed variables
Summary: USE(...) macro should expect unprefixed variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-30 10:15 PDT by Martin Robinson
Modified: 2015-05-01 16:39 PDT (History)
3 users (show)

See Also:

Attachments
Patch (47.17 KB, patch)
2015-04-30 10:22 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2015-04-30 10:15:03 PDT 
As discussed on the webkit-dev mailing list [1], unlike HAVE(...) and ENABLE(...), USE(...) looks for variables of the form WTF_USE_FOO. To make it more similar to ENABLE and HAVE, it should look for USE_FOO.

1. https://lists.webkit.org/pipermail/webkit-dev/2015-April/027408.html
Comment 1 Martin Robinson 2015-04-30 10:22:41 PDT 
Created attachment 252068 [details]
Patch
Comment 2 Daniel Bates 2015-05-01 11:05:04 PDT 
Comment on attachment 252068 [details]
Patch

Looks sane to me.
Comment 3 Martin Robinson 2015-05-01 16:39:34 PDT 
Comment on attachment 252068 [details]
Patch

Clearing flags on attachment: 252068

Committed r183697: <http://trac.webkit.org/changeset/183697>
Comment 4 Martin Robinson 2015-05-01 16:39:39 PDT 
All reviewed patches have been landed.  Closing bug.