WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
144454
USE(...) macro should expect unprefixed variables
https://bugs.webkit.org/show_bug.cgi?id=144454
Summary
USE(...) macro should expect unprefixed variables
Martin Robinson
Reported
2015-04-30 10:15:03 PDT
As discussed on the webkit-dev mailing list [1], unlike HAVE(...) and ENABLE(...), USE(...) looks for variables of the form WTF_USE_FOO. To make it more similar to ENABLE and HAVE, it should look for USE_FOO. 1.
https://lists.webkit.org/pipermail/webkit-dev/2015-April/027408.html
Attachments
Patch
(47.17 KB, patch)
2015-04-30 10:22 PDT
,
Martin Robinson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Martin Robinson
Comment 1
2015-04-30 10:22:41 PDT
Created
attachment 252068
[details]
Patch
Daniel Bates
Comment 2
2015-05-01 11:05:04 PDT
Comment on
attachment 252068
[details]
Patch Looks sane to me.
Martin Robinson
Comment 3
2015-05-01 16:39:34 PDT
Comment on
attachment 252068
[details]
Patch Clearing flags on attachment: 252068 Committed
r183697
: <
http://trac.webkit.org/changeset/183697
>
Martin Robinson
Comment 4
2015-05-01 16:39:39 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug