Bug 144452 – [GTK] Add libhyphen-dev to the build dependencies

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Xabier Rodríguez Calvar]

[GTK] Add libhyphen-dev to the build dependencies

[Xabier Rodríguez Calvar]

Created attachment 252064 [details]
Patch

libhyphen-dev seems to be needed now, otherwise compilation fails.

[WebKit Commit Bot]

Comment on attachment 252064 [details]
Patch

Clearing flags on attachment: 252064

Committed r183634: <http://trac.webkit.org/changeset/183634>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

When touching this file please be sure to add the Fedora (hyphen-devel) and Arch (hyphen) packages too.

[Xabier Rodríguez Calvar]

(In reply to comment #4)
> When touching this file please be sure to add the Fedora (hyphen-devel) and
> Arch (hyphen) packages too.

I wish this could have done with a follow up patch rather than with a rollout ;)

[Xabier Rodríguez Calvar]

(In reply to comment #5)
> (In reply to comment #4)
> > When touching this file please be sure to add the Fedora (hyphen-devel) and
> > Arch (hyphen) packages too.
> 
> I wish this could have done with a follow up patch rather than with a
> rollout ;)

Actually, it seems it is not, my bad. I thought it was an automatic rollout :D

[Xabier Rodríguez Calvar]

(In reply to comment #4)
> When touching this file please be sure to add the Fedora (hyphen-devel) and
> Arch (hyphen) packages too.

Btw, how do you test the different possibilities, just trust it?

[Michael Catanzaro]

(In reply to comment #7)
> (In reply to comment #4)
> > When touching this file please be sure to add the Fedora (hyphen-devel) and
> > Arch (hyphen) packages too.
> 
> Btw, how do you test the different possibilities, just trust it?

I just check online:

https://www.archlinux.org/packages/extra/x86_64/hyphen/

^ View file list (at the bottom of the page) shows it has /usr/lib/libhyphen.so

https://apps.fedoraproject.org/packages/hyphen-devel/

^ The Contents tab shows it contains /usr/lib64/libhyphen.so

[Xabier Rodríguez Calvar]

Created attachment 252097 [details]
Patch

Added hyphen as Arch and Fedora deps as well.

[Martin Robinson]

Comment on attachment 252097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252097&action=review

> Tools/ChangeLog:15
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * gtk/install-dependencies: Added hyphen as Fedora and Arch
> +        dependencies.
> +
> [phone]  Xabier Rodriguez Calvar  <[e-mail]>
> +
> +        [GTK] Add libhyphen-dev to the build dependencies
> +        https://bugs.webkit.org/show_bug.cgi?id=144452
> +

Your changelog has issues here, I think. Be careful when landing this that you don't insert the ChangeLog entry into the middle of the file.

[Xabier Rodríguez Calvar]

Created attachment 252137 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 252137 [details]
Patch for landing

Clearing flags on attachment: 252137

Committed r183669: <http://trac.webkit.org/changeset/183669>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.