Bug 144452 - [GTK] Add libhyphen-dev to the build dependencies
Summary: [GTK] Add libhyphen-dev to the build dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-30 10:04 PDT by Xabier Rodríguez Calvar
Modified: 2015-05-01 02:05 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.15 KB, patch)
2015-04-30 10:05 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff
Patch (1.39 KB, patch)
2015-04-30 15:53 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff
Patch for landing (1.29 KB, patch)
2015-05-01 01:13 PDT, Xabier Rodríguez Calvar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2015-04-30 10:04:01 PDT
[GTK] Add libhyphen-dev to the build dependencies
Comment 1 Xabier Rodríguez Calvar 2015-04-30 10:05:03 PDT
Created attachment 252064 [details]
Patch

libhyphen-dev seems to be needed now, otherwise compilation fails.
Comment 2 WebKit Commit Bot 2015-04-30 11:22:03 PDT
Comment on attachment 252064 [details]
Patch

Clearing flags on attachment: 252064

Committed r183634: <http://trac.webkit.org/changeset/183634>
Comment 3 WebKit Commit Bot 2015-04-30 11:22:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Michael Catanzaro 2015-04-30 12:00:37 PDT
When touching this file please be sure to add the Fedora (hyphen-devel) and Arch (hyphen) packages too.
Comment 5 Xabier Rodríguez Calvar 2015-04-30 12:25:08 PDT
(In reply to comment #4)
> When touching this file please be sure to add the Fedora (hyphen-devel) and
> Arch (hyphen) packages too.

I wish this could have done with a follow up patch rather than with a rollout ;)
Comment 6 Xabier Rodríguez Calvar 2015-04-30 12:26:36 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > When touching this file please be sure to add the Fedora (hyphen-devel) and
> > Arch (hyphen) packages too.
> 
> I wish this could have done with a follow up patch rather than with a
> rollout ;)

Actually, it seems it is not, my bad. I thought it was an automatic rollout :D
Comment 7 Xabier Rodríguez Calvar 2015-04-30 12:27:44 PDT
(In reply to comment #4)
> When touching this file please be sure to add the Fedora (hyphen-devel) and
> Arch (hyphen) packages too.

Btw, how do you test the different possibilities, just trust it?
Comment 8 Michael Catanzaro 2015-04-30 15:24:23 PDT
(In reply to comment #7)
> (In reply to comment #4)
> > When touching this file please be sure to add the Fedora (hyphen-devel) and
> > Arch (hyphen) packages too.
> 
> Btw, how do you test the different possibilities, just trust it?

I just check online:

https://www.archlinux.org/packages/extra/x86_64/hyphen/

^ View file list (at the bottom of the page) shows it has /usr/lib/libhyphen.so

https://apps.fedoraproject.org/packages/hyphen-devel/

^ The Contents tab shows it contains /usr/lib64/libhyphen.so
Comment 9 Xabier Rodríguez Calvar 2015-04-30 15:53:55 PDT
Created attachment 252097 [details]
Patch

Added hyphen as Arch and Fedora deps as well.
Comment 10 Martin Robinson 2015-04-30 16:08:54 PDT
Comment on attachment 252097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252097&action=review

> Tools/ChangeLog:15
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * gtk/install-dependencies: Added hyphen as Fedora and Arch
> +        dependencies.
> +
> +2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
> +
> +        [GTK] Add libhyphen-dev to the build dependencies
> +        https://bugs.webkit.org/show_bug.cgi?id=144452
> +

Your changelog has issues here, I think. Be careful when landing this that you don't insert the ChangeLog entry into the middle of the file.
Comment 11 Xabier Rodríguez Calvar 2015-05-01 01:13:18 PDT
Created attachment 252137 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2015-05-01 02:05:28 PDT
Comment on attachment 252137 [details]
Patch for landing

Clearing flags on attachment: 252137

Committed r183669: <http://trac.webkit.org/changeset/183669>
Comment 13 WebKit Commit Bot 2015-05-01 02:05:34 PDT
All reviewed patches have been landed.  Closing bug.