Bug 144431 - REGRESSION(183583): [Mac] make without SDKROOT has issues
Summary: REGRESSION(183583): [Mac] make without SDKROOT has issues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-29 19:22 PDT by Joseph Pecoraro
Modified: 2016-09-07 21:43 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.96 KB, patch)
2015-04-29 19:27 PDT, Joseph Pecoraro
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-04-29 19:22:56 PDT
* SUMMARY
`make` without SDKROOT has issues.

* STEPS TO REPRODUCE
1. shell> cd Tools/WebKitTestRunner
2. shell> make
  => FAILURE, attempted to build iOS Target WebKitTestRunnerApp, but we are macosx
3. shell> make SDKROOT=macosx
  => SUCCESS

* NOTES
- Caused by http://trac.webkit.org/changeset/183583
Comment 1 Joseph Pecoraro 2015-04-29 19:27:40 PDT
Created attachment 252027 [details]
[PATCH] Proposed Fix

Still running builds locally myself, but a quick test in WebKitTestRunner gave me expected results.
Comment 2 Joseph Pecoraro 2015-04-29 19:42:08 PDT
http://trac.webkit.org/changeset/183604