Bug 144117 - Linker fails without -DDEVELOPER_MODE=ON
Summary: Linker fails without -DDEVELOPER_MODE=ON
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-23 13:29 PDT by Doug Newgard
Modified: 2015-05-12 01:00 PDT (History)
2 users (show)

See Also:

Attachments
Error Log (58.81 KB, text/x-log)
2015-04-23 13:29 PDT, Doug Newgard 		no flags Details
Patch (2.62 KB, patch)
2015-05-11 21:39 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Newgard 2015-04-23 13:29:27 PDT 
Created attachment 251479 [details]
Error Log

Using cmake without -DDEVELOPER_MODE=ON causes target JSC to fail with a lot of Undefined Reference errors. See attached log.
Comment 1 Ryuan Choi 2015-05-11 21:29:10 PDT 
(In reply to comment #0)
> Created attachment 251479 [details]
> Error Log
> 
> Using cmake without -DDEVELOPER_MODE=ON causes target JSC to fail with a lot
> of Undefined Reference errors. See attached log.

It's because of visibility CXX FLAGS.

I will upload the patch not to use visibility.
We can use linker script instead of it.
Comment 2 Ryuan Choi 2015-05-11 21:39:15 PDT 
Created attachment 252931 [details]
Patch
Comment 3 Gyuyoung Kim 2015-05-12 00:11:04 PDT 
Comment on attachment 252931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252931&action=review

LGTM.

> Source/cmake/OptionsEfl.cmake:60
> +    set(WebKit2_VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter")

Oh, nice catch !
Comment 4 WebKit Commit Bot 2015-05-12 01:00:41 PDT 
Comment on attachment 252931 [details]
Patch

Clearing flags on attachment: 252931

Committed r184166: <http://trac.webkit.org/changeset/184166>
Comment 5 WebKit Commit Bot 2015-05-12 01:00:46 PDT 
All reviewed patches have been landed.  Closing bug.