Bug 143947 - HashMap storing PropertyKey StringImpl* need to use IdentifierRepHash to handle Symbols
Summary: HashMap storing PropertyKey StringImpl* need to use IdentifierRepHash to hand...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-20 01:07 PDT by Yusuke Suzuki
Modified: 2015-04-20 12:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2015-04-20 01:53 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (1.98 KB, patch)
2015-04-20 01:57 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (1.98 KB, patch)
2015-04-20 01:58 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-04-20 01:07:23 PDT 
HashMap storeing PropertyKey StringImpl* need to use IdentifierRepHash to handle Symbols
Comment 1 Yusuke Suzuki 2015-04-20 01:53:58 PDT 
Created attachment 251155 [details]
Patch
Comment 2 Yusuke Suzuki 2015-04-20 01:55:14 PDT 
Could anyone take a look?
It fixes JSC test failures in 32bit debug builds.
https://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29
Comment 3 WebKit Commit Bot 2015-04-20 01:55:45 PDT 
Attachment 251155 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yusuke Suzuki 2015-04-20 01:57:37 PDT 
Created attachment 251156 [details]
Patch
Comment 5 Yusuke Suzuki 2015-04-20 01:58:42 PDT 
Created attachment 251157 [details]
Patch
Comment 6 Geoffrey Garen 2015-04-20 11:31:10 PDT 
Comment on attachment 251157 [details]
Patch

Ha! I just had to fix this bug for another patch!
Comment 7 Geoffrey Garen 2015-04-20 11:46:13 PDT 
Comment on attachment 251157 [details]
Patch

Marking cq+ because we need this fix to fix the crash seen in https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20JSC%20%28Tests%29/builds/908/steps/jscore-test/logs/stdio.
Comment 8 WebKit Commit Bot 2015-04-20 12:36:35 PDT 
Comment on attachment 251157 [details]
Patch

Clearing flags on attachment: 251157

Committed r183022: <http://trac.webkit.org/changeset/183022>
Comment 9 WebKit Commit Bot 2015-04-20 12:36:39 PDT 
All reviewed patches have been landed.  Closing bug.