Bug 14387 - [S60] Pointer event in a blank browser window cusses crash
Summary: [S60] Pointer event in a blank browser window cusses crash
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: S60 Emulator S60 3rd edition
: P2 Blocker
Assignee: Nobody
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2007-06-25 08:33 PDT by Sachin Padma
Modified: 2011-03-21 11:53 PDT (History)
0 users

See Also:


Attachments
Null pointer check (1.13 KB, patch)
2007-06-25 08:37 PDT, Sachin Padma
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sachin Padma 2007-06-25 08:33:12 PDT
- Steps to reproduce:
Open BrowserNG, Option->Goto address, fill a non-existed local address to the address field, e.g. file://c:/ anything.htm, press open button. After  no gateway error message, a blank browser window is shown up. Click on the blank browser window	

- Actual outcome:
Crash

- Expected outcome:
Should not  crash

- Other info:
        I watched following calling sequence before crash: 
CPointerEventHandler::HandlePointerEventL -> CWebCoreBridge::ActivateEvent  ->  KWQKHTMLPart::activateNodeAtPoint

If taking a look at the last function,  renderer() returns null when there is no html document.  The return value of renderer() should be checked.
void KWQKHTMLPart::activateNodeAtPoint(const QPoint &point)
{
    // On ActivateEvent, clear the "don't submit form twice" data member.
    prepareForUserAction();

    RenderObject::NodeInfo renderInfo(true, false);
renderer()->layer()->hitTest(renderInfo, point.x(), point.y());

TSW ID: YDAI-73V998
Comment 1 Sachin Padma 2007-06-25 08:37:47 PDT
Created attachment 15222 [details]
Null pointer check
Comment 2 zalan 2007-06-25 11:51:53 PDT
Comment on attachment 15222 [details]
Null pointer check

r=me
Comment 3 Sachin Padma 2007-06-26 07:42:13 PDT
landed in r23792
Comment 4 Bradley Morrison 2008-04-09 11:39:40 PDT
Bulk closing of all s60 platform bugs. 

Sorry for the noise!
Comment 5 Joel Parks 2011-03-21 11:53:32 PDT
re-purposing InTSW keyword for use by QtWebkit team