WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
143855
Expose JavaScriptMarkupEnabled preference for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=143855
Summary
Expose JavaScriptMarkupEnabled preference for WebKit1
Sam Weinig
Reported
2015-04-16 16:23:26 PDT
Expose JavaScriptMarkupEnabled preference for WebKit1
Attachments
Patch
(4.75 KB, patch)
2015-04-16 16:25 PDT
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2015-04-16 16:25:46 PDT
Created
attachment 250974
[details]
Patch
mitz
Comment 2
2015-04-16 16:31:48 PDT
Comment on
attachment 250974
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=250974&action=review
> Source/WebKit/mac/WebView/WebPreferences.mm:2498 > +- (BOOL)isJavaScriptMarkupEnabled
The getter should just be javaScriptMarkupEnabled (see other recent examples in this class).
> Source/WebKit/mac/WebView/WebPreferencesPrivate.h:442 > +@property (nonatomic, getter=isJavaScriptMarkupEnabled) BOOL javaScriptMarkupEnabled;
So you don’t need a custom getter= here.
Sam Weinig
Comment 3
2015-04-16 17:29:20 PDT
Committed
r182928
: <
http://trac.webkit.org/changeset/182928
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug