Bug 143855 - Expose JavaScriptMarkupEnabled preference for WebKit1
Summary: Expose JavaScriptMarkupEnabled preference for WebKit1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-16 16:23 PDT by Sam Weinig
Modified: 2015-04-16 17:29 PDT (History)
0 users

See Also:

Attachments
Patch (4.75 KB, patch)
2015-04-16 16:25 PDT, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2015-04-16 16:23:26 PDT 
Expose JavaScriptMarkupEnabled preference for WebKit1
Comment 1 Sam Weinig 2015-04-16 16:25:46 PDT 
Created attachment 250974 [details]
Patch
Comment 2 mitz 2015-04-16 16:31:48 PDT 
Comment on attachment 250974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250974&action=review

> Source/WebKit/mac/WebView/WebPreferences.mm:2498
> +- (BOOL)isJavaScriptMarkupEnabled

The getter should just be javaScriptMarkupEnabled (see other recent examples in this class).

> Source/WebKit/mac/WebView/WebPreferencesPrivate.h:442
> +@property (nonatomic, getter=isJavaScriptMarkupEnabled) BOOL javaScriptMarkupEnabled;

So you don’t need a custom getter= here.
Comment 3 Sam Weinig 2015-04-16 17:29:20 PDT 
Committed r182928: <http://trac.webkit.org/changeset/182928>